WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250584
[WebRTC] Fix -Wdeprecated-copy warnings in the boringssl project
https://bugs.webkit.org/show_bug.cgi?id=250584
Summary
[WebRTC] Fix -Wdeprecated-copy warnings in the boringssl project
David Kilzer (:ddkilzer)
Reported
2023-01-13 11:00:27 PST
Fix -Wdeprecated-copy warnings in the boringssl project: Source/third_party/boringssl/src/include/openssl/bytestring.h:53:3: error: definition of implicit copy assignment operator for 'cbs_st' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy] cbs_st(const cbs_st &) = default; ^ Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/ssl/t1_lib.cc:183:14: note: in implicit copy assignment operator for 'cbs_st' first required here extensions = *cbs; ^ Source/third_party/boringssl/src/include/openssl/bytestring.h:53:3: error: definition of implicit copy assignment operator for 'cbs_st' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy] cbs_st(const cbs_st &) = default; ^ Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/ssl/handshake_server.cc:452:18: note: in implicit copy assignment operator for 'cbs_st' first required here extensions = copy; ^ Source/third_party/boringssl/src/include/openssl/bytestring.h:53:3: error: definition of implicit copy assignment operator for 'cbs_st' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy] cbs_st(const cbs_st &) = default; ^ Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/ssl/handshake.cc:176:18: note: in implicit copy assignment operator for 'cbs_st' first required here out_msg->raw = CBS(ech_client_hello_buf); ^ Fixed by upstream commit: Fix a -Wdeprecated-copy warning.
https://github.com/google/boringssl/commit/f315a86df3d5cd51135db996c9d5747ec2641331
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-01-13 11:00:51 PST
<
rdar://problem/104231355
>
David Kilzer (:ddkilzer)
Comment 2
2023-01-13 11:02:21 PST
Pull request:
https://github.com/WebKit/WebKit/pull/8631
EWS
Comment 3
2023-01-13 21:40:36 PST
Committed
258907@main
(ade6fee2858e): <
https://commits.webkit.org/258907@main
> Reviewed commits have been landed. Closing PR #8631 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug