Bug 250574 - Make functions expecting ComputedEffectTiming or BasicEffectTiming parameters use a const reference
Summary: Make functions expecting ComputedEffectTiming or BasicEffectTiming parameters...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-13 07:32 PST by Antoine Quint
Modified: 2023-01-13 12:02 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-01-13 07:32:32 PST 
There are a few methods taking in a ComputedEffectTiming or BasicEffectTiming as parameter and not using a reference thus making unnecessary copies. These should be const references.
Comment 1 Antoine Quint 2023-01-13 07:34:00 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8622
Comment 2 EWS 2023-01-13 12:01:12 PST 
Committed 258883@main (2e13a8bc0a16): <https://commits.webkit.org/258883@main>

Reviewed commits have been landed. Closing PR #8622 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-01-13 12:02:17 PST 
<rdar://problem/104234493>