WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250524
Fix nit which is inefficient sequence to deleteMarkedNodes
https://bugs.webkit.org/show_bug.cgi?id=250524
Summary
Fix nit which is inefficient sequence to deleteMarkedNodes
Ahmad Saleem
Reported
2023-01-12 13:15:57 PST
Hi Team, While going through Blink's commit, I think we can fix inefficient sequence as well: Blink Commit -
https://chromium.googlesource.com/chromium/blink/+/ec81c8eb26580fce076c096c13463d754f40e6c3
WebKit Source -
https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp#179
Move this below: m_nodesToDelete = std::exchange(m_nodesMarkedForDeletion, { }); ---> here Just wanted to raise so we can fix this. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2023-01-14 11:53:25 PST
Committed
258920@main
(6eceb6d922f3): <
https://commits.webkit.org/258920@main
> Reviewed commits have been landed. Closing PR #8590 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2023-01-14 11:54:17 PST
<
rdar://problem/104263455
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug