Bug 250517 - REGRESSION(258591@main): [iOS] TestWebKitAPI.WKWebView.LocalStorageDirectoryExcludedFromBackup is consistently failing
Summary: REGRESSION(258591@main): [iOS] TestWebKitAPI.WKWebView.LocalStorageDirectoryE...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Website Storage (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-12 09:15 PST by Ryan Haddad
Modified: 2023-01-12 12:03 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2023-01-12 09:15:55 PST 
The following test is consistently failing on iOS:

    TestWebKitAPI.WKWebView.LocalStorageDirectoryExcludedFromBackup
        2023-01-09 18:59:58.415 com.apple.WebKit.Networking.Development[49807:180526386] DiskCookieStorage changing policy from 2 to 0, cookie file: file:///Users/buildbot/Library/Developer/CoreSimulator/Devices/1C75A537-F79C-4CE6-B3FB-842E6FE9CEC5/data/Library/Cookies/com.apple.WebKit.TestWebKitAPI.2.PrivateBrowsing.6ebb0a0f-6904-43cd-acd4-e316fb2d25bf.binarycookies
        
        /Volumes/Data/worker/Apple-iOS-16-Simulator-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:548
        Value of: isDirectoryExcluded.boolValue
          Actual: false
        Expected: true

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WKWebView.LocalStorageDirectoryExcludedFromBackup
Comment 1 Radar WebKit Bug Importer 2023-01-12 09:16:19 PST 
<rdar://problem/104175904>
Comment 2 Ryan Haddad 2023-01-12 09:18:46 PST 
Regression range appears to be http://commits.webkit.org/compare/258586@main...258608@main (this failure started during a time when iOS tests were crashing, so it isn't super obvious when this failure started by just looking at the history)
Comment 3 Ryan Haddad 2023-01-12 09:19:15 PST 
https://commits.webkit.org/258591@main is about migrating CacheStorage data, so it may be relevant.
Comment 4 Sihui Liu 2023-01-12 09:53:55 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8583
Comment 5 EWS 2023-01-12 12:03:11 PST 
Committed 258844@main (2ddc3b8f7f70): <https://commits.webkit.org/258844@main>

Reviewed commits have been landed. Closing PR #8583 and removing active labels.