Bug 250503 - AX: Remove obsolete comment in AXIsolatedTree::updateChildren regarding subtree removals
Summary: AX: Remove obsolete comment in AXIsolatedTree::updateChildren regarding subtr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-11 23:01 PST by Tyler Wilcock
Modified: 2023-01-12 10:39 PST (History)
10 users (show)

See Also:

Attachments
Patch (3.30 KB, patch)
2023-01-11 23:08 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2023-01-11 23:01:44 PST 
This comment in AXIsolatedTree::updateChildren:

https://github.com/WebKit/WebKit/blob/65cbbd06b50bb3c8e45aabd0c47322e540baf4fd/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp#L609#L613

Was obsoleted by this commit:

https://github.com/WebKit/WebKit/commit/755fc266ed7bbbbcd5505c9e842d89caf9796c19

Because the referenced variable (`idsBeingChanged`) was obsoleted by checking m_unresolvedPendingAppends in AXIsolatedTree::removeSubtreeFromNodeMap (which accomplishes the same thing).
Comment 1 Radar WebKit Bug Importer 2023-01-11 23:01:55 PST 
<rdar://problem/104156450>
Comment 2 Tyler Wilcock 2023-01-11 23:08:11 PST 
Created attachment 464467 [details]
Patch
Comment 3 EWS 2023-01-12 10:39:39 PST 
Committed 258839@main (88766c1ad26b): <https://commits.webkit.org/258839@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464467 [details].