Bug 250489 - [Wasm-GC] Add missing type expansion for arrays, structs
Summary: [Wasm-GC] Add missing type expansion for arrays, structs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 247394
  Show dependency tree / graph
 
Reported: 2023-01-11 17:01 PST by Asumu Takikawa
Modified: 2023-01-18 12:03 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Asumu Takikawa 2023-01-11 17:01:49 PST 
There are a few spots where expansion of potentially recursive type definitions is missing in the Wasm GC validator and in the compiler.

This shouldn't cause any crashes, but causes some programs to not validate and run (if they use `sub` and/or `rec` in types and use arrays/structs). Some tests also need to be added for these cases.
Comment 1 Asumu Takikawa 2023-01-12 17:27:31 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8600
Comment 2 EWS 2023-01-18 12:02:04 PST 
Committed 259042@main (3304a1879844): <https://commits.webkit.org/259042@main>

Reviewed commits have been landed. Closing PR #8600 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-01-18 12:03:21 PST 
<rdar://problem/104390727>