RESOLVED FIXED250481
Improve comparison of intervals in SVGSMILElement::resolveFirstInterval 
https://bugs.webkit.org/show_bug.cgi?id=250481
Summary Improve comparison of intervals in SVGSMILElement::resolveFirstInterval
Ahmad Saleem
Reported 2023-01-11 15:15:22 PST
Hi Team, While going through Blink's commit, came across another potential fix: Commit - https://src.chromium.org/viewvc/blink?revision=175122&view=revision WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/svg/animation/SVGSMILElement.cpp#863 etc. Just wanted to raise to see if we can fix this. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Karl Dubost
Comment 1 2023-01-11 20:59:10 PST
The prose of the Blink commit. ============ Improve comparison of intervals in SVGSMILElement::resolveFirstInterval For open-ended intervals such as [3) - i.e. begin=3s and end/duration/etc unspecified - every call to resolveFirstInterval() would think that a new interval had been created, and notify/require a reschedule of the animations. Add a new type SMILInterval and a suitable operator for that, and then use it to compare the raw values (i.e. if both endpoints are exacly the same.) BUG=377329 =========== https://bugs.chromium.org/p/chromium/issues/detail?id=377329 There is a testcase in there.
Ahmad Saleem
Comment 2 2023-01-12 04:21:26 PST
(In reply to Karl Dubost from comment #1) > The prose of the Blink commit. > > ============ > Improve comparison of intervals in SVGSMILElement::resolveFirstInterval > > For open-ended intervals such as [3) - i.e. begin=3s and end/duration/etc > unspecified - every call to resolveFirstInterval() would think that a new > interval had been created, and notify/require a reschedule of the > animations. > Add a new type SMILInterval and a suitable operator for that, and then > use it to compare the raw values (i.e. if both endpoints are exacly the > same.) > > BUG=377329 > =========== > https://bugs.chromium.org/p/chromium/issues/detail?id=377329 > > > There is a testcase in there. The test need: Add a printf in SVGImageChromeClient::invalidateContentsAndRootView
Radar WebKit Bug Importer
Comment 3 2023-01-18 15:16:14 PST
<rdar://problem/104399900>
Ahmad Saleem
Comment 4 2024-08-11 01:15:18 PDT
SVN repo is gone - so alternative link - https://github.com/chromium/chromium/commit/5b93bdd34c17dae682ce14c45125abc603310b16
Ahmad Saleem
Comment 5 2025-08-23 12:32:21 PDT
Pull request: https://github.com/WebKit/WebKit/pull/49818
EWS
Comment 6 2025-08-25 07:56:23 PDT
Committed 299110@main (661903c79498): <https://commits.webkit.org/299110@main> Reviewed commits have been landed. Closing PR #49818 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.