Bug 250383 - Adjust text input scrollWidth and scrollHeight to include padding and any whitespace added by decorations
Summary: Adjust text input scrollWidth and scrollHeight to include padding and any whi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar
: 201453 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-01-10 07:03 PST by Ahmad Saleem
Modified: 2023-03-03 00:56 PST (History)
6 users (show)

See Also:

Attachments
GitHub Local Instance Patch (314.33 KB, image/png)
2023-03-01 08:29 PST, Ahmad Saleem 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-10 07:03:21 PST 
Hi Team,

While going through Blink's commit, I came across following failing test case:

Test Case - https://jsfiddle.net/2barv9Lu/

^ Safari 16.2 only passes two while Chrome Canary 111 only fail one with fraction issue while Firefox Nightly 110 passes all.

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=186123

WebKit Source - https://github.com/WebKit/WebKit/blob/28de25b653f64ca3fc8e87fbf1d1a963329a5342/Source/WebCore/rendering/RenderTextControlSingleLine.cpp#L367

Just wanted to raise so we can track and fixes these issues.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-01-17 07:04:15 PST 
<rdar://problem/104332108>
Comment 2 Ahmad Saleem 2023-03-01 08:29:33 PST 
Created attachment 465240 [details]
GitHub Local Instance Patch

Using the attached in WebKit ToT will fix this test case. Just tested locally.
Comment 3 Ahmad Saleem 2023-03-01 09:59:33 PST 
*** Bug 201453 has been marked as a duplicate of this bug. ***
Comment 4 EWS 2023-03-03 00:56:39 PST 
Committed 261121@main (393d4a1bb437): <https://commits.webkit.org/261121@main>

Reviewed commits have been landed. Closing PR #10875 and removing active labels.