Bug 250377 - [GTK][WPE] Use g_error() instead of _exit() when web process is forced to exit after connection is closed
Summary: [GTK][WPE] Use g_error() instead of _exit() when web process is forced to exi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2023-01-10 03:22 PST by Carlos Garcia Campos
Modified: 2023-01-17 16:28 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-01-10 03:22:45 PST 
To make it easier to debug the cause of the process leak.
Comment 1 Carlos Garcia Campos 2023-01-10 03:24:36 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8455
Comment 2 EWS 2023-01-12 00:42:59 PST 
Committed 258823@main (f74856909394): <https://commits.webkit.org/258823@main>

Reviewed commits have been landed. Closing PR #8455 and removing active labels.
Comment 3 Michael Catanzaro 2023-01-17 16:28:20 PST 
This was a good idea. I hit this crash several times already shortly after updating to 2.39.4, and was able to very easily see what the main thread is doing and quickly determine that the underlying problem was bug #247057. So it's immediately paying off. If the web process had been doing something else, it would have been easy to report a new bug.