Bug 250334 - REGRESSION(258522@main): Ensure the slider style is applied to an <input> element before drawing
Summary: REGRESSION(258522@main): Ensure the slider style is applied to an <input> ele...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 249168
  Show dependency tree / graph
 
Reported: 2023-01-09 12:13 PST by Said Abou-Hallawa
Modified: 2023-01-09 14:35 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-01-09 12:13:48 PST 
The appearance style can be applied to any non <input> element like this this one:

<style>
  html {
    appearance: slider-vertical;
  }
</style>

In 258522@main createSliderTrackPartForRenderer() was refactored from RenderTheme::paintSliderTicks() which makes an early return "if (!is<HTMLInputElement>(o.node()))". We need to port this check to createSliderTrackPartForRenderer().
Comment 1 Said Abou-Hallawa 2023-01-09 12:14:19 PST 
rdar://104019874
Comment 2 Said Abou-Hallawa 2023-01-09 12:19:02 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8411
Comment 3 EWS 2023-01-09 14:35:15 PST 
Committed 258684@main (c14ea6ce8716): <https://commits.webkit.org/258684@main>

Reviewed commits have been landed. Closing PR #8411 and removing active labels.