Bug 250321 - CSS font-face src local does not invalidate invalid CSS-wide keywords
Summary: CSS font-face src local does not invalidate invalid CSS-wide keywords
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vitor Roriz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-09 05:48 PST by Vitor Roriz
Modified: 2023-01-09 19:10 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitor Roriz 2023-01-09 05:48:41 PST 
When we parse src for @font-face, CSS-wide keywords are not valid for local(). In case they are the only keywords being input for local, CSSPropertyParserHelpers::concatenateFamilyName will produce a null String, but we won't invalidate the CSSValue for that case.
Comment 1 Radar WebKit Bug Importer 2023-01-09 05:48:53 PST 
<rdar://problem/104028095>
Comment 2 Vitor Roriz 2023-01-09 05:57:44 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8396
Comment 3 EWS 2023-01-09 18:57:04 PST 
Committed 258695@main (1940d518c650): <https://commits.webkit.org/258695@main>

Reviewed commits have been landed. Closing PR #8396 and removing active labels.