Bug 250297 - Fix *-baseline computation for {text-,}after-edge/ideographic/baseline
Summary: Fix *-baseline computation for {text-,}after-edge/ideographic/baseline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ahmad Saleem
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-08 06:06 PST by Ahmad Saleem
Modified: 2023-01-11 09:59 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-08 06:06:33 PST 
Hi Team,

While going through Blink's commit, I came across another one which is failing in Safari 16.2 and it would be good to merge in WebKit:

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=176877

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp#112

Failing Test Case - https://jsfiddle.net/b6tqy53h/

^ Passes in Chrome Canary 111 and Firefox Nightly 110.

Just wanted to raise this so can fix later.

Thanks!
Comment 1 Ahmad Saleem 2023-01-08 08:57:04 PST 
PR - https://github.com/WebKit/WebKit/pull/8380 (Still in Draft)
Comment 2 EWS 2023-01-11 09:58:48 PST 
Committed 258791@main (66230a3a52c0): <https://commits.webkit.org/258791@main>

Reviewed commits have been landed. Closing PR #8380 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-01-11 09:59:18 PST 
<rdar://problem/104128162>