RESOLVED FIXED250282
[Multicolumn] Guard against zero or negative space shortage 
https://bugs.webkit.org/show_bug.cgi?id=250282
Summary [Multicolumn] Guard against zero or negative space shortage
Ahmad Saleem
Reported 2023-01-07 15:50:19 PST
Hi Team, Just going through Blink's commit, which would be good to add: Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=174088 WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderMultiColumnFlow.cpp#185 Adding following early return (by following WebKit Coding Style - https://webkit.org/code-style-guidelines/#null-false-and-zero): if (!spaceShortage) return; ___ Just wanted to raise so this can be fixed for any potential debug issue. I also checked that we never imported these blink test cases etc. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2023-01-07 16:45:29 PST
> Adding following early return (by following WebKit Coding Style - https://webkit.org/code-style-guidelines/#null-false-and-zero): > if (!spaceShortage) > return; (Note that negative values are truthy, so `spaceShortage <= 0` is correct)
Ahmad Saleem
Comment 2 2023-01-08 04:16:48 PST
PR - https://github.com/WebKit/WebKit/pull/8373
alan
Comment 3 2023-01-08 15:28:36 PST
(In reply to Tim Nguyen (:ntim) from comment #1) > > Adding following early return (by following WebKit Coding Style - https://webkit.org/code-style-guidelines/#null-false-and-zero): > > > if (!spaceShortage) > > return; > > (Note that negative values are truthy, so `spaceShortage <= 0` is correct) truth!
EWS
Comment 4 2023-01-08 16:39:16 PST
Committed 258647@main (783df4eb9096): <https://commits.webkit.org/258647@main> Reviewed commits have been landed. Closing PR #8373 and removing active labels.
Radar WebKit Bug Importer
Comment 5 2023-01-08 16:40:17 PST
<rdar://problem/104011828>
Note You need to log in before you can comment on or make changes to this bug.