Hi Team, While going through Blink's commit, I came across another failing test case: Test Case - https://jsfiddle.net/xothm1vc/show ^ Safari 16.2 & STP160 only show two green rectangles. While Firefox Nightly 110 and Chrome Canary 111 show full green bar rectangle, not just two slots. Blink Commit - https://chromium.googlesource.com/chromium/blink/+/ffa39ae78904542a2864e2cb7d1c16c24ee2324e I haven't checked whether it is 1-1 merge or not but just wanted to raise for tracking. Thanks!
<rdar://problem/104262208>
WebKit ToT (263769@main) get full bar but half is 'red' while STP169 still shows only two rectangles. Just wanted to highlight small-progression.
This commit removed 'SVGFilterBuilder.cpp' in WebKit - https://commits.webkit.org/251522@main
(In reply to Ahmad Saleem from comment #2) > WebKit ToT (263769@main) get full bar but half is 'red' while STP169 still > shows only two rectangles. > > Just wanted to highlight small-progression. This is with LBSE turned on. LBSE off is still same.
Something to do here ?: https://searchfox.org/wubkat/source/Source/WebCore/svg/graphics/filters/SVGFilterGraph.h#64
This compiles and fixes this test case: RefPtr<NodeType> getNamedNode(const AtomString& id) const { if (!id.isEmpty()) { if (m_sourceNodes.contains(id)) return m_sourceNodes.get(id); if (m_namedNodes.contains(id)) return m_namedNodes.get(id); } if (m_lastNode) return m_lastNode; return sourceGraphic(); } in https://searchfox.org/wubkat/rev/7bf250e4832adfb28c2bf2bc518ad59958f2ae1b/Source/WebCore/svg/graphics/filters/SVGFilterGraph.h#78 For LBSE - there isn't any improvement or regression.
Committed 279421@main (8e028375b9c5): <https://commits.webkit.org/279421@main> Reviewed commits have been landed. Closing PR #28314 and removing active labels.