<rdar://problem/103968374>

Created attachment 464382 [details]
Patch

Created attachment 464426 [details]
Patch

Created attachment 464451 [details]
Patch

Comment on attachment 464451 [details]
Patch

thanks Andres!

Comment on attachment 464451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464451&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:4083
> +    for (AXID targetID : targetIDs)

this could be
auto targetID : targetIDs

> Source/WebCore/accessibility/AXObjectCache.cpp:4156
> +    for (size_t i = 0; i < ids.size(); ++i) {

you could store ids.size() outside the loop so it doesn't have to be called each time in the loop

(In reply to chris fleizach from comment #6)
> Comment on attachment 464451 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=464451&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:4083
> > +    for (AXID targetID : targetIDs)
> 
> this could be
> auto targetID : targetIDs
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:4156
> > +    for (size_t i = 0; i < ids.size(); ++i) {
> 
> you could store ids.size() outside the loop so it doesn't have to be called
> each time in the loop

It is an inline for Vector and most std-like collections, so there is no harm. Thanks!

Created attachment 464459 [details]
Patch

Committed 258816@main (278013ba2274): <https://commits.webkit.org/258816@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464459 [details].