Bug 250232 - [WPE][GTK] Rename environment variable for turning off sandbox
Summary: [WPE][GTK] Rename environment variable for turning off sandbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-06 14:06 PST by Michael Catanzaro
Modified: 2023-01-15 08:13 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-01-06 14:06:50 PST 
Let's split this from bug #220117. Disabling the sandbox is very useful for debugging purposes. But the name of the environment variable should be much scarier than the current WEBKIT_FORCE_SANDBOX=0. My original suggestion was WEBKIT_ALLOW_HACKING_ME=1, but Carlos Garcia and Patrick don't like this. How about WEBKIT_DISABLE_SANDBOX_THIS_IS_DANGEROUS=1?
Comment 1 Michael Catanzaro 2023-01-12 11:56:57 PST 
More possible variants of this:

WEBKIT_DANGEROUS_DISABLE_SANDBOX=1
WEBKIT_DISABLE_SANDBOX_DANGEROUS=1
WEBKIT_DISABLE_SANDBOX_DANGEROUSLY=1
Comment 2 Michael Catanzaro 2023-01-12 13:35:19 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8591
Comment 3 EWS 2023-01-15 08:13:29 PST 
Committed 258930@main (0b04b92cda5a): <https://commits.webkit.org/258930@main>

Reviewed commits have been landed. Closing PR #8591 and removing active labels.