Bug 250227 - Add exclusive "shouldBeGreaterThan" function to js-test.js similar to Chromium
Summary: Add exclusive "shouldBeGreaterThan" function to js-test.js similar to Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-06 13:10 PST by Ahmad Saleem
Modified: 2023-01-07 06:41 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-06 13:10:04 PST 
Hi Team,

While trying to do following PR and in the test of it:

https://github.com/WebKit/WebKit/pull/8305/files#diff-c2c39a91b22f93f030d4c452050c08bc0b5d2632af2f40215a5acc58582a0d9bR18

I noted that it has dedicated "shouldBeGreaterThan" test compared to "shouldBeGreaterThanOrEqual", we have.

I checked on Chromium source and they have it separate:

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/resources/js-test.js;l=601?q=shouldBeGreaterThan

I think it would be fine and good enhancement to add it for even future use cases.

Just wanted to get opinion and raise it.

Thanks!
Comment 1 EWS 2023-01-07 06:40:48 PST 
Committed 258613@main (24d9e4a1e3d3): <https://commits.webkit.org/258613@main>

Reviewed commits have been landed. Closing PR #8321 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-01-07 06:41:16 PST 
<rdar://problem/103987760>