Bug 250211 - Don't call splitTreeToNode() with null Node
Summary: Don't call splitTreeToNode() with null Node
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-06 08:10 PST by Ahmad Saleem
Modified: 2023-02-10 12:21 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-01-06 08:10:58 PST 
Hi Team,

While going through Blink's commit, came across another potential merge:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/d96d4a1c73a7a101c1065ba5e0ddf1e9dd414de6

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/editing/IndentOutdentCommand.cpp#189

Just wanted to raise this so we can fix this. It is more of debug assertion fix rather than any web-exposed feature but still good to fix.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-01-13 08:11:16 PST 
<rdar://problem/104224829>
Comment 2 Ahmad Saleem 2023-02-06 15:14:09 PST 
We already have imported this test - outdent-collapse-table-crash.html

and it seems to not cause any assertion, do we need to merge this?
Comment 3 Ryosuke Niwa 2023-02-10 12:21:09 PST 
Sounds like this is completed then.