Bug 250188 - [GTK] Remove TouchEventsEnabled from DeprecatedGlobalSettings
Summary: [GTK] Remove TouchEventsEnabled from DeprecatedGlobalSettings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: 250192
  Show dependency treegraph
 
Reported: 2023-01-05 21:24 PST by Tim Nguyen (:ntim)
Modified: 2023-01-06 16:05 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2023-01-05 21:24:33 PST
Use EnabledBySetting from IDL
Comment 1 Tim Nguyen (:ntim) 2023-01-06 00:14:53 PST
This is a fake setting only relevant to GTK (see screenHasTouchDevice), it's not in any of the YAML file.

I wonder if there is a IDL declaration that would allow checking screenHasTouchDevice without using DeprecatedGlobalSettings.
Comment 2 Radar WebKit Bug Importer 2023-01-06 12:08:23 PST
<rdar://problem/103963408>
Comment 3 Tim Nguyen (:ntim) 2023-01-06 12:10:36 PST
Pull request: https://github.com/WebKit/WebKit/pull/8315
Comment 4 EWS 2023-01-06 16:05:26 PST
Committed 258572@main (981b5db5676d): <https://commits.webkit.org/258572@main>

Reviewed commits have been landed. Closing PR #8315 and removing active labels.