Bug 250149 - Add plumbing for Gamepad.vibrationActuator support
Summary: Add plumbing for Gamepad.vibrationActuator support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks: 248989
  Show dependency tree / graph
 
Reported: 2023-01-05 14:01 PST by Chris Dumez
Modified: 2023-01-06 16:28 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-01-05 14:01:40 PST 
Add plumbing for Gamepad.vibrationActuator support:
- https://w3c.github.io/gamepad/extensions.html#dom-gamepadhapticactuator
Comment 1 Chris Dumez 2023-01-05 14:17:49 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8251
Comment 2 EWS 2023-01-06 13:57:03 PST 
Committed 258559@main (7203ee047b6c): <https://commits.webkit.org/258559@main>

Reviewed commits have been landed. Closing PR #8251 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-01-06 13:58:16 PST 
<rdar://problem/103966957>
Comment 4 Michael Catanzaro 2023-01-06 16:05:05 PST 
Looks like this broke the GTK build:

/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp: In member function ‘virtual void WebCore::EmptyGamepadProvider::playEffect(unsigned int, const WTF::String&, WebCore::GamepadHapticEffectType, const WebCore::GamepadEffectParameters&, WTF::CompletionHandler<void(bool)>&&)’:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp:52:22: error: no match for call to ‘(WTF::CompletionHandler<void(bool)>) (bool)’
   52 |     completionHandler(false);
      |     ~~~~~~~~~~~~~~~~~^~~~~~~
/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp: In member function ‘virtual void WebCore::EmptyGamepadProvider::stopEffects(unsigned int, const WTF::String&, WTF::CompletionHandler<void()>&&)’:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp:57:22: error: no match for call to ‘(WTF::CompletionHandler<void()>) ()’
   57 |     completionHandler();
      |     ~~~~~~~~~~~~~~~~~^~

The code *looks* correct, though...
Comment 5 Chris Dumez 2023-01-06 16:11:22 PST 
(In reply to Michael Catanzaro from comment #4)
> Looks like this broke the GTK build:
> 
> /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/
> EmptyGamepadProvider.cpp: In member function ‘virtual void
> WebCore::EmptyGamepadProvider::playEffect(unsigned int, const WTF::String&,
> WebCore::GamepadHapticEffectType, const WebCore::GamepadEffectParameters&,
> WTF::CompletionHandler<void(bool)>&&)’:
> /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/
> EmptyGamepadProvider.cpp:52:22: error: no match for call to
> ‘(WTF::CompletionHandler<void(bool)>) (bool)’
>    52 |     completionHandler(false);
>       |     ~~~~~~~~~~~~~~~~~^~~~~~~
> /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/
> EmptyGamepadProvider.cpp: In member function ‘virtual void
> WebCore::EmptyGamepadProvider::stopEffects(unsigned int, const WTF::String&,
> WTF::CompletionHandler<void()>&&)’:
> /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/
> EmptyGamepadProvider.cpp:57:22: error: no match for call to
> ‘(WTF::CompletionHandler<void()>) ()’
>    57 |     completionHandler();
>       |     ~~~~~~~~~~~~~~~~~^~
> 
> The code *looks* correct, though...

Maybe we need to include <wtf/CompletionHandler.h> inside EmptyGamepadProvider.cpp. Would you be able to try?
Comment 6 Michael Catanzaro 2023-01-06 16:16:03 PST 
I had the same idea. Pretty sure it worked: my build is nearly done....
Comment 7 Michael Catanzaro 2023-01-06 16:21:47 PST 
Yes, that works.
Comment 8 Michael Catanzaro 2023-01-06 16:24:23 PST 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/8331
Comment 9 EWS 2023-01-06 16:27:57 PST 
Committed 258578@main (3383a19ab4f9): <https://commits.webkit.org/258578@main>

Reviewed commits have been landed. Closing PR #8331 and removing active labels.