Bug 250099 - AX: Conversion of PDFView coordinates to screen coordinates for accessibility should happen on the main thread.
Summary: AX: Conversion of PDFView coordinates to screen coordinates for accessibility...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-04 12:46 PST by Andres Gonzalez
Modified: 2023-01-04 20:00 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.00 KB, patch)
2023-01-04 12:50 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2023-01-04 12:46:18 PST 
Failing to do so causes random crashes like: rdar://103835507
Comment 1 Radar WebKit Bug Importer 2023-01-04 12:46:31 PST 
<rdar://problem/103884859>
Comment 2 Andres Gonzalez 2023-01-04 12:50:18 PST 
Created attachment 464335 [details]
Patch
Comment 3 chris fleizach 2023-01-04 12:59:23 PST 
Comment on attachment 464335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464335&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2009
> +        return page->chrome().rootViewToScreen(enclosingIntRect(updatedRect));

return page ? page->chrome().rootViewToScreen(enclosingIntRect(updatedRect)); : { };

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2025
> +        return page->chrome().rootViewToScreen(enclosingIntRect(rectInRootViewCoordinates));

return page ? page->chrome().rootViewToScreen(enclosingIntRect(rectInRootViewCoordinates)) : { };
Comment 4 Andres Gonzalez 2023-01-04 13:13:17 PST 
(In reply to chris fleizach from comment #3)
> Comment on attachment 464335 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=464335&action=review
> 
> > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2009
> > +        return page->chrome().rootViewToScreen(enclosingIntRect(updatedRect));
> 
> return page ?
> page->chrome().rootViewToScreen(enclosingIntRect(updatedRect)); : { };
> 
> > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2025
> > +        return page->chrome().rootViewToScreen(enclosingIntRect(rectInRootViewCoordinates));
> 
> return page ?
> page->chrome().rootViewToScreen(enclosingIntRect(rectInRootViewCoordinates))
> : { };

Unfortunately you can't have an initializer list in a ? : statement. So you would need to do something like ... ? ... : FloatRect(), which is kind of ugly too. Hopefully, in C++ 26 they got that in :-).
Comment 5 EWS 2023-01-04 20:00:09 PST 
Committed 258469@main (c7cf1700de11): <https://commits.webkit.org/258469@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464335 [details].