Bug 250080 - _WKAuthenticatorAttestationResponse and _WKAuthenticatorResponse should retain/copy their instance variables
Summary: _WKAuthenticatorAttestationResponse and _WKAuthenticatorResponse should retai...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-04 09:27 PST by David Kilzer (:ddkilzer)
Modified: 2023-01-04 20:30 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-01-04 09:27:10 PST 
_WKAuthenticatorAttestationResponse and _WKAuthenticatorResponse should retain their instance variables.

Currently they are storing NSObject types as the equivalent of __unsafe_unretained, and not copying @property objects with the `copy` attribute.

Found by clang static analyzer (as leaks, but only when using getter/setter methods, not via direct assignment).
Comment 1 Radar WebKit Bug Importer 2023-01-04 09:27:38 PST 
<rdar://problem/103876775>
Comment 2 David Kilzer (:ddkilzer) 2023-01-04 10:39:06 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8198
Comment 3 EWS 2023-01-04 20:30:53 PST 
Committed 258471@main (fe1655421cc5): <https://commits.webkit.org/258471@main>

Reviewed commits have been landed. Closing PR #8198 and removing active labels.