REOPENED250040
Add EWS build step to print out contents of patch 
https://bugs.webkit.org/show_bug.cgi?id=250040
Summary Add EWS build step to print out contents of patch
pascoe@apple.com
Reported 2023-01-03 12:54:23 PST
GitHub sometimes deletes older versions of commits inside PRs after they are landed. This might be only when the author deletes their local branch or similar, but the EWS results for the previous commits are still present. It would be nice to see the commit. We could do this in the bugzilla-based patch flow, so not being able to view old versions of a patch seems to a regression moving to GitHub. To fix this I'm suggesting a build step that prints out the patch being tested against, so the contents of old commits in PRs can be viewed along with the test results.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-01-03 12:54:38 PST
<rdar://problem/103844431>
Alexey Proskuryakov
Comment 2 2023-01-04 13:43:49 PST
We'd need to be careful to not print security patches. Also, some patches are huge. Perhaps there is a way to tell GitHub to not garbage collect old PR commits?
Jonathan Bedard
Comment 3 2023-05-01 17:34:39 PDT
I don’t think we should do this. This data is available on GitHub (even if the PR has been forced pushed), see the “<person> force-pushed the <branch> branch from <hash-a> to <hash-b>. We even link to that hash in configure build, and GitHub will show you the diff.
pascoe@apple.com
Comment 4 2023-05-01 19:56:19 PDT
GitHub deletes the commits after a while. Try looking the older commits on https://github.com/WebKit/WebKit/pull/5519. It's all 404s.
pascoe@apple.com
Comment 5 2023-05-02 10:47:35 PDT
I still think this is a significant regression because of above. It makes seeing what was done to resolve comments impossible if the PR isn't recently landed.
Note You need to log in before you can comment on or make changes to this bug.