Bug 249994 - [css-nesting] Fix assert when parsing invalid CSS selector
Summary: [css-nesting] Fix assert when parsing invalid CSS selector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-02 01:42 PST by Matthieu Dubet
Modified: 2023-01-03 10:41 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Dubet 2023-01-02 01:42:35 PST 
Debug builds are reporting an assertion failure after this change.

https://results.webkit.org/?suite=layout-tests&test=fast%2Fcss%2Ffont_property_normal.html

Buildbot: builder Apple-Ventura-Debug-AppleSilicon-WK2-Tests build 569
https://build.webkit.org/#/builders/704/builds/569

fast/css/font_property_normal.html [ Crash ]
fast/css/parsing-invalid-block-recovery.html [ Crash ]

ASSERTION FAILED: scopeCombinator != CSSSelector::Subselector
css/parser/CSSSelectorParser.cpp(329) : std::unique_ptr<CSSParserSelector> WebCore::CSSSelectorParser::consumeRelativeNestedSelector(WebCore::CSSParserTokenRange &)
Comment 1 Matthieu Dubet 2023-01-02 01:43:28 PST 
Introduced by https://github.com/WebKit/WebKit/pull/8071
Comment 2 Radar WebKit Bug Importer 2023-01-02 01:44:31 PST 
<rdar://problem/103809119>
Comment 3 Matthieu Dubet 2023-01-02 01:46:20 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8124
Comment 4 EWS 2023-01-03 10:41:10 PST 
Committed 258392@main (d741aacc0a0d): <https://commits.webkit.org/258392@main>

Reviewed commits have been landed. Closing PR #8124 and removing active labels.