Bug 249958 - WebKit::WebPageProxy::takeFocus() should take a WebCore::FocusDirection
Summary: WebKit::WebPageProxy::takeFocus() should take a WebCore::FocusDirection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-30 11:25 PST by David Kilzer (:ddkilzer)
Modified: 2023-01-03 18:00 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-12-30 11:25:48 PST 
WebKit::WebPageProxy::takeFocus() should take a WebCore::FocusDirection.

It currently takes a uint32_t, and WebCore::FocusDirection is an enum class with type uint8_t.

<rdar://65494875>
Comment 1 David Kilzer (:ddkilzer) 2022-12-30 12:34:54 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8107
Comment 2 EWS 2023-01-03 18:00:27 PST 
Committed 258415@main (dc7bc53309b5): <https://commits.webkit.org/258415@main>

Reviewed commits have been landed. Closing PR #8107 and removing active labels.