Bug 249913 - Shrink isValidNameNonASCII by using U16_NEXT only once
Summary: Shrink isValidNameNonASCII by using U16_NEXT only once
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-27 13:22 PST by Ahmad Saleem
Modified: 2023-01-04 16:09 PST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-12-27 13:22:38 PST 
Hi Team,

While going through Blink's commit, I came across another which can be merged.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/dadf5a004d8cfd99fd1ef0a6a8472141f77c180f

WebKit Source - https://github.com/WebKit/WebKit/blob/f2cf9958d49b88d049bbdcbe60abdc00731910c3/Source/WebCore/dom/Document.cpp#LL5591

Just wanted to raise, if this might be needed to bring same savings.

Thanks!
Comment 1 Ryosuke Niwa 2022-12-29 14:29:31 PST 
It might be good to merge the change but it's probably not critical.
Comment 2 Radar WebKit Bug Importer 2023-01-03 13:23:15 PST 
<rdar://problem/103845492>
Comment 3 EWS 2023-01-04 16:09:14 PST 
Committed 258456@main (25d3919907b8): <https://commits.webkit.org/258456@main>

Reviewed commits have been landed. Closing PR #8191 and removing active labels.