Bug 249901 - investigate which WPT tests are being fixed by bug 175287
Summary: investigate which WPT tests are being fixed by bug 175287
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Karl Dubost
URL:
Keywords: InRadar
Depends on: 175287
Blocks:
  Show dependency treegraph
 
Reported: 2022-12-26 23:18 PST by Karl Dubost
Modified: 2023-12-12 23:16 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Dubost 2022-12-26 23:18:37 PST
In fixing Bug 175287, running the WPT test suite gave this list of bugs expected to fail but which passed. 
We should figure out which ones are really solved by the bug. 
https://github.com/WebKit/WebKit/pull/8065


```
Expected to fail, but passed: (74)
  imported/w3c/web-platform-tests/cookies/attributes/path.html
  imported/w3c/web-platform-tests/cookies/value/value.html
  imported/w3c/web-platform-tests/css/css-backgrounds/background-attachment-margin-root-001.html
  imported/w3c/web-platform-tests/css/css-backgrounds/background-clip-content-box-002.html
  imported/w3c/web-platform-tests/css/css-backgrounds/background-margin-root.html
  imported/w3c/web-platform-tests/css/css-backgrounds/background-size/background-size-contain.xht
  imported/w3c/web-platform-tests/css/css-backgrounds/background-size/background-size-cover-svg.html
  imported/w3c/web-platform-tests/css/css-backgrounds/background-size/background-size-cover.xht
  imported/w3c/web-platform-tests/css/css-backgrounds/border-image-repeat-round-1.html
  imported/w3c/web-platform-tests/css/css-backgrounds/border-radius-clip-001.html
  imported/w3c/web-platform-tests/css/css-backgrounds/css3-border-image-repeat-repeat.html
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-017.html
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-018.html
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-019.html
  imported/w3c/web-platform-tests/css/css-color/system-color-compute.html
  imported/w3c/web-platform-tests/css/css-color/system-color-consistency.html
  imported/w3c/web-platform-tests/css/css-color/t422-rgba-onscreen-b.xht
  imported/w3c/web-platform-tests/css/css-color/t422-rgba-onscreen-multiple-boxes-c.xht
  imported/w3c/web-platform-tests/css/css-color/t425-hsla-onscreen-b.xht
  imported/w3c/web-platform-tests/css/css-color/t425-hsla-onscreen-multiple-boxes-c.xht
  imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-background-properties.html
  imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-default.html
  imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image-composited-dynamic1.html
  imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image-composited-dynamic2.html
  imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image-composited.html
  imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image-dynamic1.html
  imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image-dynamic2.html
  imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image.html
  imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-none-image-document.html
  imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-none.html
  imported/w3c/web-platform-tests/css/css-images/multiple-position-color-stop-conic-2.html
  imported/w3c/web-platform-tests/css/css-images/tiled-conic-gradients.html
  imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-polygon-013.html
  imported/w3c/web-platform-tests/css/css-multicol/zero-column-width-layout.html
  imported/w3c/web-platform-tests/css/css-position/multicol/static-position/vlr-ltr-ltr-in-multicol.html
  imported/w3c/web-platform-tests/css/css-position/multicol/static-position/vrl-ltr-ltr-in-multicol.html
  imported/w3c/web-platform-tests/css/css-pseudo/highlight-cascade-004.html
  imported/w3c/web-platform-tests/css/css-pseudo/highlight-pseudos-computed.html
  imported/w3c/web-platform-tests/css/css-pseudo/placeholder-excluded-properties.html
  imported/w3c/web-platform-tests/css/css-transforms/individual-transform/animation/individual-transform-ordering.html
  imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle.html
  imported/w3c/web-platform-tests/css/css-typed-om/width-by-clamp-px-em.html
  imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em.html
  imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em.html
  imported/w3c/web-platform-tests/css/css-ui/appearance-menulist-button-002.tentative.html
  imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-menulist-button-002.tentative.html
  imported/w3c/web-platform-tests/css/css-writing-modes/float-lft-orthog-htb-in-vlr-002.xht
  imported/w3c/web-platform-tests/css/css-writing-modes/float-rgt-orthog-htb-in-vlr-003.xht
  imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block.html
  imported/w3c/web-platform-tests/css/filter-effects/css-filters-animation-opacity.html
  imported/w3c/web-platform-tests/css/filter-effects/effect-reference-displacement-negative-scale-001.html
  imported/w3c/web-platform-tests/css/filter-effects/effect-reference-local-url-with-base-001.html
  imported/w3c/web-platform-tests/css/filter-effects/effect-reference-rename-002.html
  imported/w3c/web-platform-tests/css/filter-effects/fecomposite-non-zero-inoffset-001.html
  imported/w3c/web-platform-tests/css/filter-effects/svg-mutation-function-to-url.html
  imported/w3c/web-platform-tests/html/canvas/element/line-styles/2d.line.miter.obtuse.html
  imported/w3c/web-platform-tests/html/canvas/element/manual/drawing-images-to-the-canvas/image-orientation/drawImage-from-blob.tentative.html
  imported/w3c/web-platform-tests/html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected.html
  imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/imageBitmapRendering-transferFromImageBitmap-webgl.html
  imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-video.html
  imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html
  imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.arc.selfintersect.1.html
  imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.arc.shape.3.html
  imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-N-between-Rs.html
  imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs.html
  imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-cell-nowrap-with-fixed-width.html
  imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-list-item-numbering.html
  imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-list-item.html
  imported/w3c/web-platform-tests/quirks/line-height-in-list-item.tentative.html
  imported/w3c/web-platform-tests/svg/import/animate-elem-35-t-manual.svg
  imported/w3c/web-platform-tests/svg/path/distance/pathlength-path.svg
  imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-relay-canvas.https.html
  imported/w3c/web-platform-tests/xhr/event-timeout-order.any.worker.html
  imported/w3c/web-platform-tests/xhr/setrequestheader-case-insensitive.htm
```

Tim suggests two strategies:

   A. You can make a separate follow up PR that removes all of these for the TestExpectations, run them through EWS, and then put them back as you see failures. 
OR B. Manual inspection works too

Probably A. would be better as it would allow to explore things which are probably not visible to the naked eye.


Maybe a similar strategy would be to explore for the fast tests.
Comment 1 Radar WebKit Bug Importer 2022-12-26 23:18:49 PST
<rdar://problem/103721463>
Comment 2 Karl Dubost 2022-12-27 18:42:57 PST
Pull request: https://github.com/WebKit/WebKit/pull/8081
Comment 3 Karl Dubost 2023-12-12 23:16:01 PST
Probably not relevant anymore.