Bug 249882 - [IFC] Add explanation why we find justification opportunities within preserved whitespace
Summary: [IFC] Add explanation why we find justification opportunities within preserve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-25 07:37 PST by zalan
Modified: 2022-12-25 19:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.49 KB, patch)
2022-12-25 08:01 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.16 KB, patch)
2022-12-25 12:32 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-12-25 07:37:14 PST 
ssia
Comment 1 zalan 2022-12-25 08:01:21 PST 
Created attachment 464204 [details]
Patch
Comment 2 Antti Koivisto 2022-12-25 08:22:46 PST 
Comment on attachment 464204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464204&action=review

> LayoutTests/TestExpectations:2871
> +webkit.org/b/249881 imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-014.html [ ImageOnlyFailure ]

or you could just fix the test.
Comment 3 zalan 2022-12-25 09:59:51 PST 
or maybe not:

https://bugs.chromium.org/p/chromium/issues/detail?id=336636

"According to the CSS3 spec, a UA can determine whether
or not it wishes to apply text-align: justify to text
with collapsible spaces[1]. Currently, we disable
whitespace expansion whenever we aren't collapsing
spaces, but this doesn't make a lot of sense for pre-
wrap text, since aside from not collapsing spaces,
flows text around lines like usual."

https://lists.w3.org/Archives/Public/www-style/2014Apr/0481.html
Comment 4 zalan 2022-12-25 12:30:26 PST 
repurposed.
Comment 5 zalan 2022-12-25 12:32:43 PST 
Created attachment 464208 [details]
Patch
Comment 6 EWS 2022-12-25 19:01:39 PST 
Committed 258333@main (224844a635de): <https://commits.webkit.org/258333@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464208 [details].
Comment 7 Radar WebKit Bug Importer 2022-12-25 19:02:17 PST 
<rdar://problem/103701524>