Bug 249879 - Move PNG row decode colorChannels definition to where used
Summary: Move PNG row decode colorChannels definition to where used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-25 01:26 PST by Ahmad Saleem
Modified: 2023-06-11 06:39 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-12-25 01:26:57 PST 
Hi Team,

Just wanted to raise it another bug report, which might be good to merge:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/6a8b3bdbb22821f68d4e3da67bf2be13ef521d9b

WebKit GitHub Source - https://github.com/WebKit/WebKit/blob/98a28389be81009e2d4470d70fd7869a726e549f/Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp#L518

^ Move Line 515 below 518.

It is part of major refactoring done by Chromium but just wanted to raise it since it will move the definition where it is used.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-01-01 01:27:15 PST 
<rdar://problem/103797795>
Comment 2 EWS 2023-06-11 06:39:27 PDT 
Committed 265060@main (4f973fcc4d4a): <https://commits.webkit.org/265060@main>

Reviewed commits have been landed. Closing PR #14850 and removing active labels.