Bug 249875 - AX: indeterminate progress elements are not reported as indeterminate by VoiceOver
Summary: AX: indeterminate progress elements are not reported as indeterminate by Voic...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-24 19:26 PST by Tyler Wilcock
Modified: 2022-12-25 17:51 PST (History)
10 users (show)

See Also:

Attachments
Patch (20.82 KB, patch)
2022-12-24 19:42 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (20.78 KB, patch)
2022-12-24 20:00 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (17.88 KB, patch)
2022-12-25 09:04 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (18.64 KB, patch)
2022-12-25 14:14 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-12-24 19:26:49 PST 
AX: indeterminate progress elements are not reported as indeterminate by VoiceOver
Comment 1 Radar WebKit Bug Importer 2022-12-24 19:27:00 PST 
<rdar://problem/103690774>
Comment 2 Tyler Wilcock 2022-12-24 19:42:20 PST 
Created attachment 464199 [details]
Patch
Comment 3 Tyler Wilcock 2022-12-24 20:00:36 PST 
Created attachment 464201 [details]
Patch
Comment 4 chris fleizach 2022-12-24 21:38:27 PST 
Comment on attachment 464201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464201&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1919
> +        return [NSNumber numberWithBool: backingObject->isIndeterminate()];

Space after : nit
Comment 5 chris fleizach 2022-12-24 23:21:51 PST 
Comment on attachment 464201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464201&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1908
> +- (id)_accessibilityAttributeValueForTesting:(NSString *)attributeName

why can't we use the normal interfaces for testing this? seems like we'd want to check the same thing the platform code will use
Comment 6 Tyler Wilcock 2022-12-25 09:04:10 PST 
Created attachment 464206 [details]
Patch
Comment 7 Tyler Wilcock 2022-12-25 09:05:23 PST 
(In reply to chris fleizach from comment #5)
> Comment on attachment 464201 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=464201&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1908
> > +- (id)_accessibilityAttributeValueForTesting:(NSString *)attributeName
> 
> why can't we use the normal interfaces for testing this? seems like we'd
> want to check the same thing the platform code will use
OK, removed _accessibilityAttributeValueForTesting and moved handling of the attribute to the normal accessibilityAttributeValue interface.
Comment 8 Tyler Wilcock 2022-12-25 14:14:20 PST 
Created attachment 464210 [details]
Patch
Comment 9 EWS 2022-12-25 17:51:01 PST 
Committed 258332@main (ece8b0ebf62d): <https://commits.webkit.org/258332@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464210 [details].