Bug 249785 - Hook up willStartRenderingUpdateDisplay/didCompleteRenderingUpdateDisplay for WC
Summary: Hook up willStartRenderingUpdateDisplay/didCompleteRenderingUpdateDisplay for WC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-22 10:04 PST by Simon Fraser (smfr)
Modified: 2023-01-05 12:36 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2023-01-04 21:35 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-12-22 10:04:54 PST 
In bug 249750/258248@main I added Page:: willStartRenderingUpdateDisplay() and Page:: didCompleteRenderingUpdateDisplay(), which get called before and after the painting phase and compositing phase of a rendering update. These are used to drive web inspector's "Composite" timeline events, and will also be used for other things soon.

WebKit2 clients can call these via the same-named functions on WebPage.

These need hooking up for WC, at the DrawingArea level.
Comment 1 Radar WebKit Bug Importer 2022-12-29 10:05:29 PST 
<rdar://problem/103762121>
Comment 2 Fujii Hironori 2023-01-04 21:26:32 PST 
258311@main (bug#249807) added another hook didCompleteRenderingFrame.
https://github.com/WebKit/WebKit/commit/bf82da4c0e3bbd409f44510fa9f3d1891808d770
Comment 3 Fujii Hironori 2023-01-04 21:35:28 PST 
Created attachment 464342 [details]
Patch
Comment 4 EWS 2023-01-05 12:36:08 PST 
Committed 258501@main (27763ea20188): <https://commits.webkit.org/258501@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464342 [details].