Bug 249760 - Match epsilon value to output digits in TextStream.cpp
Summary: Match epsilon value to output digits in TextStream.cpp
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-21 18:44 PST by Ahmad Saleem
Modified: 2023-10-18 15:25 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-12-21 18:44:20 PST 
Hi Team,

I noticed that Blink team added this commit to reduce flakiness in the test cases (especially SVG), I just wanted to get opinion whether it is something worth adding or changing in WebKit:

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=186819

Webkit GitHub Source - https://src.chromium.org/viewvc/blink?view=revision&revision=186819

Commit message crux:

"This patch brings epsilon to 0.01 so we shouldn't change whether or not we display a fraction
without a numerical difference in our output."

Just wanted to get opinion.

Thanks!
Comment 1 Alexey Proskuryakov 2022-12-21 19:50:34 PST 
Looks like we have this code in Source/WTF/wtf/text/TextStream.cpp, but I don't really know what it's meant to do. 

I don't think that we have any flakiness in render tree dumps, although we do have platform specific results that differ only a little.
Comment 2 zalan 2022-12-21 21:16:50 PST 
I am not aware of any flakiness either.
Comment 3 Radar WebKit Bug Importer 2022-12-28 18:45:16 PST 
<rdar://problem/103750146>
Comment 4 Ahmad Saleem 2023-10-18 15:25:07 PDT 
Nothing much to do here.