Bug 249705 - Potential Assertion Fix in Multicolumn - Give up on stretching columns if they have already reached max height
Summary: Potential Assertion Fix in Multicolumn - Give up on stretching columns if the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-21 03:38 PST by Ahmad Saleem
Modified: 2022-12-21 19:08 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-12-21 03:38:03 PST
Hi Team,

While going through Blink, I came across another potential assertion fix, which can make Webkit's layout and rendering more robust.

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=192636

Webkit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderMultiColumnSet.cpp#245

___

if (m_computedColumnHeight >= m_maxColumnHeight) {

// comments

return m_computedColumnHeight;
}

___

Just wanted to raise this bug so we can also add this fix.

Thanks!
Comment 1 EWS 2022-12-21 19:07:13 PST
Committed 258230@main (3edf242b588b): <https://commits.webkit.org/258230@main>

Reviewed commits have been landed. Closing PR #7953 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2022-12-21 19:08:17 PST
<rdar://problem/103622112>