RESOLVED WONTFIX249643
[CSS Shapes] Clamp reference box to zero for the reference box calculation in the MarginBox case 
https://bugs.webkit.org/show_bug.cgi?id=249643
Summary [CSS Shapes] Clamp reference box to zero for the reference box calculation in...
Ahmad Saleem
Reported 2022-12-20 03:59:18 PST
Hi Team, While going through Blink's commit, I came across following: Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=192180 Webkit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp#116 If we can add clamping similar to Blink for the cases where due to negative margin on negative width/heights, we can fix assertion and crashes. Appreciate if someone can confirm if it is worth fixing and I am happy to do PR. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-12-27 04:00:16 PST
<rdar://problem/103725054>
Ahmad Saleem
Comment 2 2023-05-06 18:38:18 PDT
This works: void ShapeOutsideInfo::invalidateForSizeChangeIfNeeded() { auto newSize = computeLogicalBoxSize(m_renderer, m_renderer.containingBlock()->isHorizontalWritingMode()); +++++ newSize.clampNegativeToZero(); if (m_cachedShapeLogicalSize == newSize) return;
Ahmad Saleem
Comment 3 2023-09-23 18:02:40 PDT
Confirmed, we don't crash the test case from Blink commit in release and debug (thanks Tim for confirming on debug build). Marking this as 'RESOLVED WONTFIX'.
Note You need to log in before you can comment on or make changes to this bug.