WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
249612
Fix issue where WebAuth timeouts lead to an incorrect error
https://bugs.webkit.org/show_bug.cgi?id=249612
Summary
Fix issue where WebAuth timeouts lead to an incorrect error
Charlie Wolfe
Reported
2022-12-19 15:28:42 PST
When an auth prompt times out it leads to an HierarchyRequestError, which is incorrect.
Attachments
Add attachment
proposed patch, testcase, etc.
Charlie Wolfe
Comment 1
2022-12-19 15:29:10 PST
rdar://100825830
Charlie Wolfe
Comment 2
2022-12-19 15:36:06 PST
Pull request:
https://github.com/WebKit/WebKit/pull/7879
EWS
Comment 3
2022-12-19 18:31:18 PST
Committed
258116@main
(56aa37f2fb91): <
https://commits.webkit.org/258116@main
> Reviewed commits have been landed. Closing PR #7879 and removing active labels.
Robert Jenner
Comment 4
2022-12-20 11:20:29 PST
It appears that this commit broke the following two API tests for iOS: TestWebKitAPI.WebAuthenticationPanel.GetAssertionCrossPlatform TestWebKitAPI.WebAuthenticationPanel.GetAssertionSPITimeout HISTORY:
https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebAuthenticationPanel.GetAssertionCrossPlatform&test=TestWebKitAPI.WebAuthenticationPanel.GetAssertionSPITimeout
I have confirmed that the regression point was
258116@main
because the tests fail at that commit, but pass at the commit directly before it.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug