Bug 249602 - Update EventHandler::nodeWillBeRemoved to cover ShadowDOM as well
Summary: Update EventHandler::nodeWillBeRemoved to cover ShadowDOM as well
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-19 12:56 PST by Ahmad Saleem
Modified: 2022-12-19 22:07 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-12-19 12:56:10 PST 
Hi Team,

Based on discussion with Ryosuke on Slack, it seems that the function should have "containsIncludingShadowDOM" rather than just "contain".

https://github.com/WebKit/WebKit/blob/af67e80850c1e752b05548a41f4d507272c8e7bf/Source/WebCore/page/EventHandler.cpp#L431

This bug is just to fix this and have ShadowDOM coverage.

Thanks!
Comment 1 EWS 2022-12-19 22:06:48 PST 
Committed 258122@main (3499e2bc4f43): <https://commits.webkit.org/258122@main>

Reviewed commits have been landed. Closing PR #7868 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2022-12-19 22:07:18 PST 
<rdar://problem/103544698>