Bug 249595 - Add signposts and profiling support to MotionMark
Summary: Add signposts and profiling support to MotionMark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: hysu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-19 10:42 PST by hysu
Modified: 2023-06-07 12:07 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hysu 2022-12-19 10:42:30 PST 
By default, trying to profile MotionMark may sometimes result in the profile being cut off before the test finishes due to file size issues. Support for subtests was added with https://bugs.webkit.org/show_bug.cgi?id=247907, so subtests should be enabled for MotionMark and profiling support should require a subtest to be specified (to avoid the test cutting off). 

Also, the test should support signposting to help label generated profiles. It may be useful to label both the warmup and the test-ready phases.
Comment 1 Radar WebKit Bug Importer 2022-12-19 10:42:55 PST 
<rdar://problem/103522107>
Comment 2 hysu 2023-06-06 17:59:00 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14717
Comment 3 EWS 2023-06-07 12:07:30 PDT 
Committed 264951@main (7627468cdd1d): <https://commits.webkit.org/264951@main>

Reviewed commits have been landed. Closing PR #14717 and removing active labels.