Bug 249589 - [web-animations] adopt AnimatableProperty in ElementRareAnimationData and CSSTransition
Summary: [web-animations] adopt AnimatableProperty in ElementRareAnimationData and CSS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 249399
  Show dependency tree / graph
 
Reported: 2022-12-19 10:03 PST by Antoine Quint
Modified: 2022-12-19 20:14 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-12-19 10:03:46 PST 
ElementRareAnimationData and CSSTransition still use CSSPropertyID instead of AnimatableProperty, as well as Styleable which deals with data structures exposed through ElementRareAnimationData. We need to make those adopt AnimatableProperty in order to support CSS Transitions of custom properties (see bug 249399).
Comment 1 Antoine Quint 2022-12-19 10:07:29 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7856
Comment 2 EWS 2022-12-19 20:13:48 PST 
Committed 258120@main (79a040808a38): <https://commits.webkit.org/258120@main>

Reviewed commits have been landed. Closing PR #7856 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-12-19 20:14:16 PST 
<rdar://problem/103542359>