Bug 249580 - Evaluate string::adopt function usage and if it can be now removed
Summary: Evaluate string::adopt function usage and if it can be now removed
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-19 08:55 PST by Ahmad Saleem
Modified: 2022-12-26 08:56 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-12-19 08:55:34 PST 
Hi,

This bug is based on @Darin's comment on PR7827:

https://github.com/WebKit/WebKit/pull/7827#pullrequestreview-1222082977

It is following:

'If this eliminates all uses of the String::adopt function that takes a vector, then that function should also be removed from the String class.'

Quick search shows that it is currently used across various files:


Source/WTF/wtf/URLParser.cpp
Source/WebCore/platform/text/LocaleICU.cpp <--- PR was modifying this file
Source/WTF/wtf/URLHelpers.cpp
Source/WebCore/PAL/pal/text/win/TextCodecWin.cpp
Source/JavaScriptCore/runtime/JSDateMath.cpp
Source/WebKit/UIProcess/Inspector/Mac/RemoteWebInspectorUIProxyMac.mm
...

Just wanted to raise this to get input and also to track it for future purposes.

Thanks!
Comment 1 Radar WebKit Bug Importer 2022-12-26 08:56:15 PST 
<rdar://problem/103711236>