Bug 249530 - [web-animations] consider using Ref<> instead of RefPtr<> in the various types defined in WebAnimationTypes.h
Summary: [web-animations] consider using Ref<> instead of RefPtr<> in the various type...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-17 03:02 PST by Antoine Quint
Modified: 2023-01-08 02:53 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-12-17 03:02:12 PST 
During review of the patch for bug 249498, Darin made a comment (https://github.com/WebKit/WebKit/pull/7780#discussion_r1051307179) that we should consider using Ref<> instead of RefPtr<> for the new AnimatablePropertyToTransitionMap. We should broadly look into using Ref<> instead of RefPtr<> for the various types defined in WebAnimationTypes.h.
Comment 1 Radar WebKit Bug Importer 2022-12-24 03:03:15 PST 
<rdar://problem/103683475>
Comment 2 Antoine Quint 2023-01-07 12:59:35 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8361
Comment 3 EWS 2023-01-08 02:53:33 PST 
Committed 258631@main (866813ec2e4e): <https://commits.webkit.org/258631@main>

Reviewed commits have been landed. Closing PR #8361 and removing active labels.