Bug 249498 - [web-animations] add an AnimatableProperty type to encapsulate either a standard or custom property
Summary: [web-animations] add an AnimatableProperty type to encapsulate either a stand...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 249399 249533
  Show dependency tree / graph
 
Reported: 2022-12-16 14:13 PST by Antoine Quint
Modified: 2022-12-17 04:53 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-12-16 14:13:12 PST 
The animation code is currently heavily biased towards dealing with "standard" CSS properties, represented by the CSSPropertyID type. However, with the work to add interpolation support for custom properties (see bug 249293) and to support CSS Transitions for custom properties (see bug 249399), we really need to deal with both custom properties and standard properties everywhere we currently deal with only standard properties. So let's add a new type, AnimatableProperty, which is an std::variant<CSSPropertyID, AtomString>.
Comment 1 Antoine Quint 2022-12-16 14:20:18 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7780
Comment 2 EWS 2022-12-17 03:13:17 PST 
Committed 258040@main (ea7b3989b369): <https://commits.webkit.org/258040@main>

Reviewed commits have been landed. Closing PR #7780 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-12-17 03:14:14 PST 
<rdar://problem/103477720>