Bug 249496 - [git-webkit] Cap identifier and revision size
Summary: [git-webkit] Cap identifier and revision size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-16 12:52 PST by Jonathan Bedard
Modified: 2023-01-12 13:40 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-12-16 12:52:04 PST 
If we have a commit with many integers in it's hash (like https://commits.webkit.org/254217@main), the truncated hash will be treated as an identifier or revision in tooling instead of a hash. This can cause bugs. In practice, identifiers and revisions can be assumed to be capped at some limited length.
Comment 1 Radar WebKit Bug Importer 2022-12-16 12:52:39 PST 
<rdar://problem/103457359>
Comment 2 Jonathan Bedard 2022-12-16 12:56:29 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7773
Comment 3 EWS 2022-12-16 14:51:49 PST 
Committed 258020@main (b38081b1f854): <https://commits.webkit.org/258020@main>

Reviewed commits have been landed. Closing PR #7773 and removing active labels.
Comment 4 EWS 2023-01-12 13:40:32 PST 
Committed 252432.1027@safari-7614-branch (6b850b31d5e3): <https://commits.webkit.org/252432.1027@safari-7614-branch>

Reviewed commits have been landed. Closing PR #284 and removing active labels.