Bug 249495 - Introduce CallFrame::returnPCForInspection(), and removed some unused code.
Summary: Introduce CallFrame::returnPCForInspection(), and removed some unused code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-16 12:49 PST by Mark Lam
Modified: 2022-12-16 15:59 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-12-16 12:49:43 PST 
CallFrame::returnPC() was relying on ReturnAddressPtr, which in turn expected to be able to untag any arbitrary return address read from a stack frame.  This will not always be possible when JITCage is enabled.  Also, CallFrame::returnPC() is only used for debugging purposes.  So, this patch will simplify its implementation and rename it to CallFrame::returnPCForInspection() to make it clear that it should only be used for debugging and analysis purposes.

We will also remove some related unused code.
Comment 1 Radar WebKit Bug Importer 2022-12-16 12:50:07 PST 
<rdar://problem/103457282>
Comment 2 Mark Lam 2022-12-16 13:10:17 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7775
Comment 3 EWS 2022-12-16 15:58:52 PST 
Committed 258023@main (689b0ba375c8): <https://commits.webkit.org/258023@main>

Reviewed commits have been landed. Closing PR #7775 and removing active labels.