Bug 249484 - [ews-build.webkit.org] Support proxy Twisted requests
Summary: [ews-build.webkit.org] Support proxy Twisted requests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 250771
  Show dependency tree / graph
 
Reported: 2022-12-16 10:19 PST by Jonathan Bedard
Modified: 2023-01-18 10:29 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-12-16 10:19:55 PST 
We have future plans to host ews-build.wekbit.org in a location where requests need to be made through a proxy. Twisted doesn't support 'HTTP_PROXY' environment variables as many libraries do. Additionally, it's not quite trivial to support proxy requests in Twisted. We need to implement proxy requests in Twisted and generalize them sufficiently so that we don't have to duplicate code in all places we're making requests in EWS.
Comment 1 Radar WebKit Bug Importer 2022-12-16 10:22:23 PST 
<rdar://problem/103451811>
Comment 2 Jonathan Bedard 2022-12-16 10:28:16 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7760
Comment 3 EWS 2022-12-16 16:43:10 PST 
Committed 258027@main (055b0ba705b4): <https://commits.webkit.org/258027@main>

Reviewed commits have been landed. Closing PR #7760 and removing active labels.