Bug 249460 - web platform tests that build up keydown and keyup events using test_driver.Actions fail
Summary: web platform tests that build up keydown and keyup events using test_driver.A...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-16 01:30 PST by Ryosuke Niwa
Modified: 2023-02-03 10:40 PST (History)
5 users (show)

See Also:

Attachments
WIP (7.93 KB, patch)
2022-12-16 01:30 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
WIP2 (6.93 KB, patch)
2022-12-16 01:32 PST, Ryosuke Niwa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP3 (6.84 KB, patch)
2022-12-19 22:42 PST, Ryosuke Niwa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2022-12-16 01:30:34 PST 
WPT tests that use test_driver.Actions.keyDown/keyUp straight up fail.
Comment 1 Ryosuke Niwa 2022-12-16 01:30:59 PST 
Created attachment 464071 [details]
WIP
Comment 2 Ryosuke Niwa 2022-12-16 01:32:44 PST 
Created attachment 464072 [details]
WIP2
Comment 3 EWS Watchlist 2022-12-16 01:36:36 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 Tim Nguyen (:ntim) 2022-12-16 01:43:07 PST 
Comment on attachment 464072 [details]
WIP2

View in context: https://bugs.webkit.org/attachment.cgi?id=464072&action=review

> LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:287
> +    if (keySource && pointerSource)
> +        throw new Error("testdriver-vendor.js for WebKit does not yet support mixing key and pointer sources");

Here's how the logic could be refactored to support both at once: https://bugs.webkit.org/attachment.cgi?id=461570&action=review

(This is a WIP for wheel actions in WKTR, very similar to what you're doing here)
Comment 5 Ryosuke Niwa 2022-12-19 22:42:09 PST 
Created attachment 464112 [details]
WIP3
Comment 6 Radar WebKit Bug Importer 2022-12-23 01:31:20 PST 
<rdar://problem/103664916>
Comment 7 Ryosuke Niwa 2023-01-31 19:11:04 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9426
Comment 8 EWS 2023-02-03 10:40:44 PST 
Committed 259822@main (790c299b40fb): <https://commits.webkit.org/259822@main>

Reviewed commits have been landed. Closing PR #9426 and removing active labels.