Bug 249431 - [IFC][Integration] RenderBox should not call first/lastLineBox on RenderInline
Summary: [IFC][Integration] RenderBox should not call first/lastLineBox on RenderInline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-15 14:45 PST by zalan
Modified: 2022-12-16 08:50 PST (History)
11 users (show)

See Also:

Attachments
[fast-cq]Patch (5.60 KB, patch)
2022-12-15 14:48 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-12-15 14:45:51 PST 
use the iterator interface instead.
Comment 1 zalan 2022-12-15 14:48:09 PST 
Created attachment 464063 [details]
[fast-cq]Patch
Comment 2 Antti Koivisto 2022-12-16 08:02:38 PST 
Comment on attachment 464063 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464063&action=review

> Source/WebCore/rendering/RenderBox.cpp:3946
> +        auto inlineBox = firstInlineBox;
> +        for (; inlineBox->nextInlineBox(); inlineBox.traverseNextInlineBox()) { }
> +        return inlineBox;

Should add lastInlineBoxFor at some point
Comment 3 EWS 2022-12-16 08:42:23 PST 
Committed 257992@main (cf7c7c33a97c): <https://commits.webkit.org/257992@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464063 [details].
Comment 4 Radar WebKit Bug Importer 2022-12-16 08:43:18 PST 
<rdar://problem/103448489>
Comment 5 zalan 2022-12-16 08:50:11 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 464063 [details]
> [fast-cq]Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=464063&action=review
> 
> > Source/WebCore/rendering/RenderBox.cpp:3946
> > +        auto inlineBox = firstInlineBox;
> > +        for (; inlineBox->nextInlineBox(); inlineBox.traverseNextInlineBox()) { }
> > +        return inlineBox;
> 
> Should add lastInlineBoxFor at some point
totally