Bug 249338 - run-benchmark should not limit profile collection to macOS platforms
Summary: run-benchmark should not limit profile collection to macOS platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: hysu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-14 14:26 PST by hysu
Modified: 2022-12-19 17:00 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hysu 2022-12-14 14:26:39 PST 
Running browser benchmarks through run-benchmark should not limit profile collection (--profile) to macOS platforms.
It may also be preferable to break the generated profile filename into directory and filename components, to avoid assumptions as to where the final profile will end up.
Comment 1 Radar WebKit Bug Importer 2022-12-14 14:27:02 PST 
<rdar://problem/103372861>
Comment 2 hysu 2022-12-14 15:19:45 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7643
Comment 3 EWS 2022-12-19 17:00:07 PST 
Committed 258109@main (b5a473c9f6d7): <https://commits.webkit.org/258109@main>

Reviewed commits have been landed. Closing PR #7643 and removing active labels.