Bug 249320 - [web-animations] Refactor CSSPropertyAnimation::blendProperties()
Summary: [web-animations] Refactor CSSPropertyAnimation::blendProperties()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 249293
  Show dependency tree / graph
 
Reported: 2022-12-14 09:40 PST by Antoine Quint
Modified: 2022-12-15 03:25 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-12-14 09:40:05 PST 
During a pull request review (https://github.com/WebKit/WebKit/pull/7615#discussion_r1048703175), Antti made the point that the CSSPropertyBlendingClient parameters which are always pointers ought to be reference since they're never null.
Comment 1 Antoine Quint 2022-12-15 01:25:07 PST 
Actually, we'll reuse this bug for a more general refactoring of CSSPropertyAnimation::blendProperties() to deal with not only a reference for CSSPropertyBlendingClient but also a variant parameter for the property to deal with both standard properties and custom properties.
Comment 2 Antoine Quint 2022-12-15 03:01:52 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7678
Comment 3 EWS 2022-12-15 03:24:02 PST 
Committed 257910@main (24ceea27a0d5): <https://commits.webkit.org/257910@main>

Reviewed commits have been landed. Closing PR #7678 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-12-15 03:25:19 PST 
<rdar://problem/103396354>