WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
249274
[run-webkit-tests] Process names do not have extensions
https://bugs.webkit.org/show_bug.cgi?id=249274
Summary
[run-webkit-tests] Process names do not have extensions
Jonathan Bedard
Reported
2022-12-13 16:23:17 PST
In
https://bugs.webkit.org/show_bug.cgi?id=248745
, I tried to fix a bug where tests with multiple periods in their name would resolve the wrong link. I managed to fix this situation in some cases, but didn't cover all of them. This is because I was checking the length of the second "extension" instead of the first. I could fix this bug, but clearly, this code is confusing me and others, so I tracked down when this was added,
https://bugs.webkit.org/show_bug.cgi?id=160198
. The problem I was trying to fix involved crash logs gathered at the end of a test run not associated to any test, and run-webkit-tests was assigning those crash logs "names" which were the name of the process. If you strip the "extension" from a string like "com.apple.WebKit.WebContent", you basically end up with a bunch of "com.apple.WebKit" processes, which isn't right. Really, We should look for file "names" which are explicitly process names instead of trying to guess based on the number of characters in an extension, which is an opaque way to solve this problem.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-12-13 16:23:35 PST
<
rdar://problem/103326384
>
Jonathan Bedard
Comment 2
2022-12-13 16:26:40 PST
Pull request:
https://github.com/WebKit/WebKit/pull/7582
EWS
Comment 3
2022-12-19 16:19:46 PST
Committed
258104@main
(ab68abe37c22): <
https://commits.webkit.org/258104@main
> Reviewed commits have been landed. Closing PR #7582 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug