Bug 249267 - Optimize Element::attributeChanged()
Summary: Optimize Element::attributeChanged()
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-13 15:37 PST by Ahmad Saleem
Modified: 2023-09-09 15:31 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-12-13 15:37:10 PST
Hi Team,

We are fastest in the benchmarks mentioned in the following Blink Commit, but I am raising this to see if this can be salvaged or if similar can be applied to further improve the performance or this is something already achieved and don't serve any benefit.

This is just to get input.

Performance Benchmark: https://jsfiddle.net/hr7Lm5jq/ & https://jsfiddle.net/x3kv4gut/

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/3ac59c7df4f1f92a3ec0fa712a14810d62b02204

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/bfd520b659e89b66f32b4863609a704e8c81357f/Source/WebCore/dom/Element.cpp#L2000

Just wanted to raise this for input.

Thanks!
Comment 1 Radar WebKit Bug Importer 2022-12-20 15:38:17 PST
<rdar://problem/103574052>
Comment 2 Darin Adler 2023-01-30 15:16:44 PST
This optimization is about code that is totally different in Blink. We don’t have this isPresentationAttribute concept. Not sure we have something analogous.
Comment 3 Ahmad Saleem 2023-09-09 15:31:53 PDT
Safari Technology Preview 178 is faster than Chrome Canary 118 and Firefox Nightly 118 in both performance benchmarks.

Closing it as 'RESOLVED WORKSFORME'.